Skip to content

Handle variable scope for default values correctly#2

Merged
BanglanfengPan merged 1 commit into
masterfrom
default-value-fix
Mar 7, 2023
Merged

Handle variable scope for default values correctly#2
BanglanfengPan merged 1 commit into
masterfrom
default-value-fix

Conversation

@BanglanfengPan

@BanglanfengPan BanglanfengPan commented Mar 7, 2023

Copy link
Copy Markdown
Collaborator

This PR is cherry-picked from tmrts#84 to fix tmrts#79

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@agonzale34 agonzale34 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agonzale34

Copy link
Copy Markdown
Collaborator

@BanglanfengPan after this get merge, we have a github action that will build all the binaries, when you create a new release, we should be able to create a new tag, most likely 0.3.2 and create a release so we get all the binaries built

@BanglanfengPan BanglanfengPan merged commit 890551b into master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--use-defaults emplacing wrong values.

4 participants