-
Notifications
You must be signed in to change notification settings - Fork 26
feat: auth services v10 & wallet-service changes. #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
384c6bd
a417645
2a8b259
1ceec38
954f652
95b3770
5d11e38
4eb997c
aed178f
0f6f226
523d7b7
a1c557b
2c018c4
c533d2f
f7bcce8
36daf96
ddf64fa
e2df060
f164b3a
ba50b30
d359522
85d55ed
6f13df3
17949df
f5b738b
87134a1
885c61d
e818026
42f2b6b
14407a0
77c35f3
8770759
025c962
8516c2e
6016bd1
bf17edb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| #Fri Jun 23 08:50:38 CEST 2017 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| https://github.com/Web3Auth/web3auth-flutter-sdk/pull/104/conflict?name=example%252Fandroid%252Fapp%252Fsrc%252Fmain%252FAndroidManifest.xml&ancestor_oid=ec00abe0c8ddb6dfa91343c66f24e48b431d1a15&base_oid=697fc9ac55830ca35e100ca84d4439da7ffddd85&head_oid=479557102c69887429d4fb9b8c21bf4760acb305distributionPath=wrapper/dists | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Merge conflict URL corrupts gradle-wrapper.properties fileHigh Severity A GitHub merge conflict URL was accidentally concatenated with the Reviewed by Cursor Bugbot for commit bf17edb. Configure here. |
||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip | ||
|
|
||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused
objvariables left after removing redirectUrl handlingLow Severity
In the
connectTo,enableMFA, andmanageMFAcases,val obj = JSONObject(loginArgs)is created but never read. These were previously used to extractredirectUrl, but theredirectUrlhandling was removed while theobjcreation was left behind. Each one performs unnecessary JSON parsing at runtime.Additional Locations (2)
android/src/main/kotlin/com/web3auth/flutter/web3auth_flutter/Web3AuthFlutterPlugin.kt#L211-L212android/src/main/kotlin/com/web3auth/flutter/web3auth_flutter/Web3AuthFlutterPlugin.kt#L260-L261Reviewed by Cursor Bugbot for commit bf17edb. Configure here.