Add conservative audit baselines and local review annotations - #5269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
audit baseline-export,baseline-compare, andbaseline-reviewusing the existing audit recipe engine. Local, versioned baselines store evidence hashes and review provenance without source snippets. Comparisons report bounded new/unchanged/resolved/unknown groups and preserve unknown outcomes when coverage, scope, workspace identity, or evidence cannot support resolution.Baseline files use bounded parsing and atomic private writes with explicit overwrite. Review decisions apply only to unchanged compatible evidence. CLI help/completions, English/Japanese README and developer/testing guidance, and JSON contract snapshots are included.
Validation
GoldenJsonPayloads_AreUniqueAndCheckedIn_Issue4166: the two new snapshots were not yet registered. Registration is fixed, and that test plus the affected baseline/audit/help contracts passed in the 340-test run above. No full-suite pass is claimed for the final merged commit.dotnet build -p:UseSharedCompilation=false.dotnet format CodeIndex.sln --verify-no-changes --no-restore.dotnet run --project tools/CodeIndex.Changelog -- check.No blocking/actionable issues found.Changelog fragment:
changelog.d/unreleased/5261.added.md.Fixes #5261