ci: harden workflow (split jobs, caching, windows leg, audit) - #60
Merged
Conversation
Split into format / build-and-test / build-and-test-windows / dependency-audit jobs. Add concurrency cancel, least-priv permissions, per-job timeouts, and NuGet caching. Tests now run in Release against the existing build (no Debug recompile). Windows leg covers the win-x64 release target; audit fails on vulnerable packages except the already accepted (and suppressed) Tmds.DBus.Protocol advisory. The build-and-test job name is preserved so the required status check keeps reporting without any branch-protection change. Co-Authored-By: Rooty
The Windows CI leg surfaced three tests baking in Unix path strings: - AppSettings roundtrip used a non-fully-qualified path that Validate() correctly prunes on Windows; use a temp-rooted (fully qualified) path - two dry-run rename tests hardcoded the expected directory with forward slashes; derive it via Path.GetDirectoryName to match the node output Production code was correct in all three; only the tests assumed Unix. Co-Authored-By: Rooty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rework the single ubuntu
build-and-testjob into a stronger, parallel pipeline.Baseline hardening
concurrencywithcancel-in-progress— stale runs no longer pile uppermissions: contents: read— least-privilege tokentimeout-minutes--no-build), dropping the redundant Debug recompileNew jobs
format— split out so style fails fastbuild-and-test-windows— mirrors the ubuntu job on the actual release target (win-x64)dependency-audit— fails on vulnerable packages, reports deprecated onesNotes
build-and-testjob name is preserved, so the existing required status check keeps reporting — no branch-protection change needed. The new jobs appear as additional checks you can promote to required whenever you like.Tmds.DBus.Protocol(Linux-only, transitive via Avalonia, already suppressed inDirectory.Build.props) so it gates on new advisories only.