Export: Stabilize pattern sanitization - #865
Open
MaggieCabrera wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the export pipeline’s defense-in-depth for wp_block pattern bodies by ensuring PHP-tag sanitization is applied repeatedly until the content no longer changes, preventing adjacent fragments from combining into newly-detectable PHP open-tag sequences after earlier removals.
Changes:
- Update
CBT_Theme_Patterns::strip_php_tags()to iterate sanitization passes until the output is stable. - Add PHPUnit coverage for overlapping
<?fragments and for cases where legacy<script language="php">…</script>removal can expose new<?sequences.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
includes/create-theme/theme-patterns.php |
Makes strip_php_tags() repeat sanitization passes until no further changes occur, preventing bypass via adjacent-fragment recombination. |
tests/test-theme-patterns.php |
Adds tests that assert sanitization stability for overlapping-open-tag and legacy-script-removal edge cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repeat pattern sanitization until the exported content is stable.
This keeps adjacent fragments from forming a new removable sequence after an earlier replacement.
Test plan
vendor/bin/phpunit -c phpunit.xml.dist --verbose --filter Test_Create_Block_Theme_Patternsvendor/bin/phpcs --standard=phpcs.xml.dist includes/create-theme/theme-patterns.php tests/test-theme-patterns.php