Lodash: Remove completely from @wordpress/format-library package#43738
Merged
Conversation
tyxla
added
[Type] Performance
tyxla
requested review from
antonis,
aristath,
chad1008,
fabiankaegy,
geriux,
gziolo,
jorgefilipecosta,
ntsekouras and
swissspidy
aristath
approved these changes
Aug 31, 2022
Member
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
I didn't test on mobile, but tested on desktop and reviewed the code. LGTM! 👍
|
Size Change: +2.5 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Member
Author
Thanks, @aristath! I'll hold off merging until the React Native folks to confirm this isn't breaking anything on mobile. |
tyxla
force-pushed
the
remove/lodash-format-library
branch
from
58fd841 to
6d7aafa
Compare
dcalhoun
requested changes
Sep 1, 2022
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Thank you for notifying the mobile team. 🙇🏻
I tested these changes on an iPhone simulator and Android emulator. I encountered one crash that we should resolve before merging this work please.
Co-authored-by: David Calhoun <438664+dcalhoun@users.noreply.github.com>
Member
Author
|
Feedback has been addressed - could I get one last look, @dcalhoun? |
Member
Author
|
Thank you, @dcalhoun 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
@wordpress/format-librarypackage, including thelodashdependency altogether. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing a few usages with their native counterparts.
Testing Instructions