fix: Add perf tests for escrow create and escrow finish#7789
Open
TimothyBanks wants to merge 8 commits into
Open
fix: Add perf tests for escrow create and escrow finish#7789TimothyBanks wants to merge 8 commits into
TimothyBanks wants to merge 8 commits into
Conversation
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
| auto mock = HostFunctions{env.journal}; | ||
| auto hfns = TestHostFunctions{env, 0}; | ||
|
|
||
| perf(hfns, kRuns, [&] { return !preflightEscrowWasm(wasm, mock, escrowFunctionName); }); |
Contributor
There was a problem hiding this comment.
mock is passed to preflightEscrowWasm but perf() checks hfns.execTimeEvent->count — assertion always fails. Pass hfns instead:
Suggested change
| perf(hfns, kRuns, [&] { return !preflightEscrowWasm(wasm, mock, escrowFunctionName); }); | |
| perf(hfns, kRuns, [&] { return !preflightEscrowWasm(wasm, hfns, escrowFunctionName); }); |
Contributor
There was a problem hiding this comment.
Had a look at this
Two correctness issues flagged inline: nanosecond timing is silently truncated to milliseconds by Event::notify (both timing sites in WasmVM.cpp), and the destructor unconditionally prints to stdout for every test instance, not just the perf tests.
Review by ReviewBot 🤖
Review by Claude Sonnet 4.6 · Prompt: V15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds very simple perf test around escrow create and escrow finish calls.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)