refactor: SField and TER code renames#7797
Open
ricky122-5 wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Stacked on top of #7696 |
mvadari
approved these changes
Jul 15, 2026
mvadari
left a comment
mvadari
left a comment
Collaborator
There was a problem hiding this comment.
PR needs to be renamed to include the SField renames
ricky122-5
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Renames TER codes to updated spec
Renames four Smart Escrow TER codes:
tecWASM_REJECTED -> tecBYTECODE_REJECTED
tefNO_WASM -> tefNO_BYTECODE
tefWASM_FIELD_NOT_INCLUDED -> tefBYTECODE_NOT_INCLUDED
temBAD_WASM -> temINVALID_BYTECODE
Compute->Gas, Wasm->VM, FinishFunction->Bytecode
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)