Skip to content

refactor: Expand AccountSetFlags macro with account_info data#7798

Draft
mvadari wants to merge 1 commit into
developfrom
mvadari/asf-macro
Draft

refactor: Expand AccountSetFlags macro with account_info data#7798
mvadari wants to merge 1 commit into
developfrom
mvadari/asf-macro

Conversation

@mvadari

@mvadari mvadari commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

This PR refactors the ACCOUNTSET_FLAGS macro to incorporate the flag info that is included in account_info.

Context of Change

Code cleanup, preventing the ability to forget to add flags in account_info

API Impact

There are some flag renames, which may impact downstream users, but mildly.

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

@mvadari mvadari changed the title refactor: Expand AccountSetFlags macro with account_info data refactor: Expand AccountSetFlags macro with account_info data Jul 13, 2026
@mvadari
mvadari marked this pull request as draft July 13, 2026 17:02
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.6%. Comparing base (2b4d067) to head (3ec960e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7798   +/-   ##
=======================================
  Coverage     82.6%   82.6%           
=======================================
  Files         1036    1036           
  Lines        79870   79871    +1     
  Branches      8949    8949           
=======================================
+ Hits         65956   65963    +7     
+ Misses       13905   13899    -6     
  Partials         9       9           
Files with missing lines Coverage Δ
include/xrpl/protocol/TxFlags.h 100.0% <ø> (ø)
src/libxrpl/tx/Transactor.cpp 90.8% <ø> (ø)
src/libxrpl/tx/transactors/account/AccountSet.cpp 97.2% <100.0%> (ø)
src/xrpld/rpc/handlers/account/AccountInfo.cpp 85.4% <100.0%> (+0.1%) ⬆️

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant