Skip to content

[DO NOT MERGE] feat: DynamicMPT new version#7819

Closed
mvadari wants to merge 10 commits into
developfrom
mvadari/dynamic-mpt-v2-coverage
Closed

[DO NOT MERGE] feat: DynamicMPT new version#7819
mvadari wants to merge 10 commits into
developfrom
mvadari/dynamic-mpt-v2-coverage

Conversation

@mvadari

@mvadari mvadari commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This is @yinyiqian1's PR, just collecting coverage

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mvadari mvadari changed the title feat: DynamicMPT new version [DO NOT MERGE] feat: DynamicMPT new version Jul 16, 2026

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Review by Claude Sonnet 4.6 · Prompt: V15

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.4%. Comparing base (5ce0b1c) to head (82e945a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7819     +/-   ##
=========================================
- Coverage     82.5%   82.4%   -0.0%     
=========================================
  Files         1039    1039             
  Lines        80446   80448      +2     
  Branches      9080    9085      +5     
=========================================
- Hits         66332   66317     -15     
- Misses       14105   14122     +17     
  Partials         9       9             
Files with missing lines Coverage Δ
include/xrpl/protocol/LedgerFormats.h 100.0% <ø> (ø)
include/xrpl/protocol/TxFlags.h 100.0% <ø> (ø)
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
.../protocol_autogen/ledger_entries/MPTokenIssuance.h 100.0% <100.0%> (ø)
...tocol_autogen/transactions/MPTokenIssuanceCreate.h 100.0% <100.0%> (ø)
...protocol_autogen/transactions/MPTokenIssuanceSet.h 100.0% <100.0%> (ø)
.../xrpl/tx/transactors/token/MPTokenIssuanceCreate.h 100.0% <ø> (ø)
...rpl/tx/transactors/token/MPTokenIssuanceCreate.cpp 94.3% <100.0%> (ø)
...ibxrpl/tx/transactors/token/MPTokenIssuanceSet.cpp 97.1% <100.0%> (+<0.1%) ⬆️
... and 1 more

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants