Skip to content

feat: Split LoanSet and LoanAccept#7820

Open
a1q123456 wants to merge 1 commit into
developfrom
a1q123456/split-loan-set-and-loan-accept-implementation
Open

feat: Split LoanSet and LoanAccept#7820
a1q123456 wants to merge 1 commit into
developfrom
a1q123456/split-loan-set-and-loan-accept-implementation

Add pending loan fields and LoanAccept for LendingProtocolV1_1

e32b303
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 17, 2026 in 1s

82.5% (target 75.0%)

View this Pull Request on Codecov

82.5% (target 75.0%)

Details

Codecov Report

❌ Patch coverage is 91.28065% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.5%. Comparing base (5ce0b1c) to head (e32b303).

Files with missing lines Patch % Lines
src/libxrpl/tx/transactors/lending/LoanSet.cpp 85.7% 14 Missing ⚠️
src/libxrpl/ledger/helpers/LendingHelpers.cpp 89.2% 10 Missing ⚠️
src/libxrpl/tx/transactors/lending/LoanAccept.cpp 90.4% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #7820    +/-   ##
========================================
  Coverage     82.5%   82.5%            
========================================
  Files         1039    1042     +3     
  Lines        80446   80713   +267     
  Branches      9080    9086     +6     
========================================
+ Hits         66332   66573   +241     
- Misses       14105   14131    +26     
  Partials         9       9            
Files with missing lines Coverage Δ
include/xrpl/ledger/helpers/LendingHelpers.h 96.6% <ø> (ø)
include/xrpl/protocol/LedgerFormats.h 100.0% <ø> (ø)
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <100.0%> (ø)
...nclude/xrpl/protocol_autogen/ledger_entries/Loan.h 100.0% <100.0%> (ø)
...clude/xrpl/protocol_autogen/ledger_entries/Vault.h 100.0% <100.0%> (ø)
...de/xrpl/protocol_autogen/transactions/LoanAccept.h 100.0% <100.0%> (ø)
...de/xrpl/protocol_autogen/transactions/LoanDelete.h 100.0% <ø> (ø)
...clude/xrpl/protocol_autogen/transactions/LoanSet.h 100.0% <100.0%> (ø)
include/xrpl/tx/transactors/lending/LoanAccept.h 100.0% <100.0%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.