fix: MPT Transfer Fee shouldn't be bypassable via Small-Amount Escrow Rounding#7821
Open
Kassaking7 wants to merge 6 commits into
Open
fix: MPT Transfer Fee shouldn't be bypassable via Small-Amount Escrow Rounding#7821Kassaking7 wants to merge 6 commits into
Kassaking7 wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
When an MPT-denominated EscrowFinish transaction computes the transfer fee owed to the issuer, it uses divideRound(amount, lockedRate, asset, roundUp=true) to compute the net amount delivered to the receiver. Rounding the net up implies rounding the fee down. For MPT (whose amounts are strict integers), and because the underlying canonicalizeRound approximation discards the fractional remainder after the intermediate divide-by-ten loops, the resulting fee collapses to exactly zero whenever the escrowed amount is small enough.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)