Skip to content

Hook Administrator Amendment [DO NOT MERGE]#662

Open
tequdev wants to merge 25 commits into
devfrom
HookAdministrator
Open

Hook Administrator Amendment [DO NOT MERGE]#662
tequdev wants to merge 25 commits into
devfrom
HookAdministrator

Update tx_flags.h

b5fdae6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 9, 2026 in 1s

77.3% (target 60.0%)

View this Pull Request on Codecov

77.3% (target 60.0%)

Details

Codecov Report

❌ Patch coverage is 64.28571% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.3%. Comparing base (c55420b) to head (b5fdae6).

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/SetHook.cpp 63.3% 29 Missing ⚠️
src/xrpld/app/tx/detail/DeleteAccount.cpp 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             dev    #662     +/-   ##
=======================================
- Coverage   77.3%   77.3%   -0.0%     
=======================================
  Files        837     837             
  Lines      78575   78654     +79     
  Branches   11551   11568     +17     
=======================================
+ Hits       60748   60784     +36     
- Misses     17817   17860     +43     
  Partials      10      10             
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
src/xrpld/app/tx/detail/InvariantCheck.cpp 90.5% <100.0%> (+<0.1%) ⬆️
src/xrpld/app/tx/detail/DeleteAccount.cpp 83.0% <50.0%> (-0.4%) ⬇️
src/xrpld/app/tx/detail/SetHook.cpp 80.2% <63.3%> (-1.3%) ⬇️

... and 9 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.