Skip to content

retire fixXahauV1, fixXahauV2 Amendments#722

Open
tequdev wants to merge 25 commits into
Xahau:devfrom
tequdev:retire-fixXahauV1V2
Open

retire fixXahauV1, fixXahauV2 Amendments#722
tequdev wants to merge 25 commits into
Xahau:devfrom
tequdev:retire-fixXahauV1V2

Merge branch 'dev' into retire-fixXahauV1V2

dd1d4a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 5, 2026 in 0s

77.2% (target 60.0%)

View this Pull Request on Codecov

77.2% (target 60.0%)

Details

Codecov Report

❌ Patch coverage is 91.39073% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.2%. Comparing base (c55420b) to head (dd1d4a6).

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/URIToken.cpp 86.5% 12 Missing ⚠️
src/xrpld/app/hook/detail/applyHook.cpp 97.1% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             dev    #722     +/-   ##
=======================================
- Coverage   77.3%   77.2%   -0.1%     
=======================================
  Files        837     837             
  Lines      78575   78272    -303     
  Branches   11551   11528     -23     
=======================================
- Hits       60747   60463    -284     
+ Misses     17818   17799     -19     
  Partials      10      10             
Files with missing lines Coverage Δ
src/xrpld/app/hook/detail/HookAPI.cpp 88.3% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/CancelOffer.cpp 81.6% <100.0%> (-2.0%) ⬇️
src/xrpld/app/tx/detail/Escrow.cpp 84.3% <100.0%> (-0.6%) ⬇️
src/xrpld/app/tx/detail/GenesisMint.cpp 82.3% <ø> (-1.5%) ⬇️
src/xrpld/app/tx/detail/Import.cpp 75.9% <100.0%> (-0.1%) ⬇️
src/xrpld/app/tx/detail/Invoke.cpp 96.9% <ø> (-0.9%) ⬇️
src/xrpld/app/tx/detail/SetHook.cpp 81.1% <100.0%> (-0.4%) ⬇️
src/xrpld/app/tx/detail/Transactor.cpp 85.4% <100.0%> (-<0.1%) ⬇️
src/xrpld/ledger/detail/ApplyStateTable.cpp 93.2% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/hook/detail/applyHook.cpp 85.3% <97.1%> (-0.2%) ⬇️
... and 1 more

... and 9 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.