Skip to content

Fix update-bank-transaction 400 when editing line items #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedromachados wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix update-bank-transaction 400 when editing line items #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/handlers/update-xero-bank-transaction.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,17 @@ async function updateBankTransaction(
reference?: string,
date?: string
): Promise<BankTransaction | undefined> {
// Build a minimal payload with only editable fields plus the attributes Xero
// requires on update. Do NOT spread the fetched object: it carries read-only
// computed fields (subTotal/total/totalTax, updatedDateUTC, etc.) that go
// stale when lineItems change, causing a 400 "The document sub total does not
// equal the sub total of the lines". Omitting the totals lets Xero recompute.
const bankTransaction: BankTransaction = {
...existingBankTransaction,
bankTransactionID: bankTransactionId,
bankAccount: existingBankTransaction.bankAccount,
lineAmountTypes: existingBankTransaction.lineAmountTypes,
status: existingBankTransaction.status,
currencyCode: existingBankTransaction.currencyCode,
type: type ? BankTransaction.TypeEnum[type] : existingBankTransaction.type,
contact: contactId ? { contactID: contactId } : existingBankTransaction.contact,
lineItems: lineItems ? lineItems : existingBankTransaction.lineItems,
Expand Down