feat(tools): add optional currencyRate param to multicurrency tools#196
Open
Zechst wants to merge 1 commit into
Open
feat(tools): add optional currencyRate param to multicurrency tools#196Zechst wants to merge 1 commit into
Zechst wants to merge 1 commit into
Conversation
Expose currencyRate on create/update operations for invoices, payments, credit notes, and quotes. Previously missing, causing failures when working with non-base currency transactions. The field already exists on all xero-node SDK types but was not wired through to the tool layer. Affected tools: create-invoice, update-invoice, create-payment, create-credit-note, update-credit-note, create-quote, update-quote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
currencyRateas an optional parameter on all create/update tools that support multicurrency transactionsxero-nodeSDK types but was not wired through to the tool layerAffected tools
create-invoice/update-invoicecreate-paymentcreate-credit-note/update-credit-notecreate-quote/update-quoteBehaviour
currencyRateis omitted, Xero defaults to the XE.com day rate (existing behaviour unchanged)Test plan
currencyRate— confirm Xero accepts itcurrencyRate— confirm no errorcurrencyRate— confirm existing behaviour unchanged