Skip to content

fix: forward paymentsOnly and standardLayout correctly#198

Open
miachillgood wants to merge 1 commit into
XeroAPI:mainfrom
miachillgood:codex/fix-profit-loss-payments-only
Open

fix: forward paymentsOnly and standardLayout correctly#198
miachillgood wants to merge 1 commit into
XeroAPI:mainfrom
miachillgood:codex/fix-profit-loss-payments-only

Conversation

@miachillgood

@miachillgood miachillgood commented Jun 11, 2026

Copy link
Copy Markdown

Summary

  • pass both paymentsOnly and standardLayout through to getReportProfitAndLoss in the correct positions
  • add a handler test that verifies the SDK receives those arguments without positional drift

Why

Issue #138 reports that paymentsOnly has no effect in get-profit-and-loss. The handler accepted both paymentsOnly and standardLayout, but only forwarded one boolean argument into getReportProfitAndLoss. That shifted standardLayout into the paymentsOnly slot and dropped the real standardLayout value before the SDK call.

Validation

  • npm test
  • npm run lint

Closes #138

@miachillgood miachillgood marked this pull request as ready for review June 12, 2026 11:40
@miachillgood miachillgood changed the title [codex] Fix paymentsOnly forwarding in profit and loss handler fix: forward paymentsOnly and standardLayout correctly Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

list-profit-and-loss: paymentsOnly parameter may not be reaching the Xero API

1 participant