Skip to content

refactor(cmd/evm): improve block/state test runner #30633#2309

Open
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:cmd-evm2
Open

refactor(cmd/evm): improve block/state test runner #30633#2309
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:cmd-evm2

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

@gzliudan gzliudan commented Apr 16, 2026

Proposed changes

Ref: ethereum#30633

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5a2e957e-1478-4f6a-83ef-35994b46a907

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors cmd/evm state test execution to support better batching/filtering/benchmarking and consolidates CLI/debug/tracing behavior.

Changes:

  • Add StateTest.RunWithGas to return gas usage alongside the post-state.
  • Rework evm statetest to support batch mode (stdin), filtering (regex/fork/index), benchmarking, and a new reporter/human output.
  • Refactor evm run execution/benchmarking and migrate global debug/profiling flags to internal/debug.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
tests/state_test_util.go Adds RunWithGas to return gas used from state test execution.
internal/debug/flags.go Extends debug flag aliases (notably memprofile).
cmd/evm/staterunner.go Refactors statetest runner to support batch mode, filtering, bench, and reporting.
cmd/evm/runner.go Refactors run command: new benchmarking (timedExec), prestate init, hex parsing, trie preimages handling.
cmd/evm/reporter.go New reporting layer for state tests (human + JSON output).
cmd/evm/main.go Reworks flags/tracing, wires in internal/debug Setup/Exit, adds helpers (collectFiles/dump/tracerFromFlags).
cmd/evm/eest.go New helper to parse EEST metadata from test names.
cmd/evm/internal/compiler/compiler.go Removed (compile support removed).
cmd/evm/compiler.go Removed compile command.
cmd/evm/disasm.go Removed disasm command.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/evm/eest.go Outdated
Comment thread cmd/evm/main.go Outdated
Comment thread cmd/evm/main.go Outdated
Comment thread cmd/evm/runner.go
Comment thread cmd/evm/runner.go Outdated
Comment thread cmd/evm/staterunner.go
Comment thread cmd/evm/eest.go Outdated
Comment thread internal/debug/flags.go Outdated
Comment thread cmd/evm/runner.go Outdated
Comment thread cmd/evm/staterunner.go Outdated
@gzliudan gzliudan requested a review from Copilot April 16, 2026 07:06
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/evm/runner.go
Comment thread cmd/evm/main.go Outdated
Comment thread cmd/evm/main.go
Comment thread tests/state_test_util.go Outdated
Comment thread cmd/evm/staterunner.go Outdated
Comment thread cmd/evm/staterunner.go Outdated
@gzliudan gzliudan requested a review from Copilot April 16, 2026 08:03
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/evm/staterunner.go
Comment thread cmd/evm/main.go Outdated
Comment thread cmd/evm/runner.go
@gzliudan gzliudan requested a review from Copilot April 16, 2026 08:31
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/evm/termutil.go Outdated
Comment thread cmd/evm/termutil_windows.go Outdated
Comment thread cmd/evm/staterunner.go Outdated
Comment thread cmd/evm/main.go Outdated
Comment thread cmd/evm/main.go
Comment thread cmd/evm/main.go
Comment thread cmd/evm/runner.go Outdated
Comment thread cmd/evm/reporter.go Outdated
Comment thread cmd/evm/main.go
Comment thread cmd/evm/runner.go
@gzliudan gzliudan requested a review from Copilot April 16, 2026 08:43
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/evm/main.go
Comment thread cmd/evm/staterunner.go
Comment thread cmd/evm/termutil.go Outdated
Comment thread cmd/evm/termutil_windows.go Outdated
@gzliudan gzliudan requested a review from Copilot April 16, 2026 09:42
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/evm/staterunner.go Outdated
Comment thread cmd/evm/runner.go
Comment thread cmd/evm/staterunner.go
@gzliudan gzliudan force-pushed the cmd-evm2 branch 2 times, most recently from 2b42e72 to 2fff4c0 Compare April 17, 2026 08:26
@gzliudan gzliudan requested a review from Copilot April 17, 2026 08:57
Copilot AI reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/evm/runner.go Outdated
Comment thread cmd/evm/staterunner.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wanwiset25 wanwiset25 wanwiset25 approved these changes

@benjamin202410 benjamin202410 benjamin202410 approved these changes

@anunay-xin anunay-xin anunay-xin approved these changes

@liam-lai liam-lai Awaiting requested review from liam-lai

@AnilChinchawale AnilChinchawale Awaiting requested review from AnilChinchawale

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gzliudan @wanwiset25 @benjamin202410 @anunay-xin