Skip to content

docs(core/state,core/vm): clarify Exist self-destruct semantics #31809#2315

Open
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:fix-core-comments
Open

docs(core/state,core/vm): clarify Exist self-destruct semantics #31809#2315
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:fix-core-comments

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

Proposed changes

Clarify that Exist returns true for self-destructed accounts only within the current transaction. Align the StateDB interface comment with the StateDB implementation comment.

Ref: ethereum#31809

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

…eum#31809

Clarify that Exist returns true for self-destructed accounts only within the current transaction.
Align the StateDB interface comment with the StateDB implementation comment.
Copilot AI review requested due to automatic review settings April 17, 2026 10:10
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc7da9e2-1b44-4789-9e96-a56e35dad06f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Clarifies the semantics of StateDB.Exist for self-destructed accounts, aligning the interface documentation (core/vm) with the concrete StateDB implementation (core/state) so readers understand the behavior is scoped to the current transaction.

Changes:

  • Update StateDB.Exist doc comment to specify it returns true for self-destructed accounts only within the current transaction.
  • Align the core/vm StateDB interface comment with the core/state StateDB implementation comment.
  • Minor formatting/spacing adjustments in the interface for readability.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core/vm/interface.go Updates StateDB.Exist interface comment to clarify self-destruct “existence” is only within the current transaction (and adds spacing for readability).
core/state/statedb.go Updates the StateDB.Exist implementation comment to match the clarified semantics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants