Skip to content

perf(core/vm): hoist jumptable nil-check out of the interpreter loop #32068#2318

Open
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:table-nil-check
Open

perf(core/vm): hoist jumptable nil-check out of the interpreter loop #32068#2318
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:table-nil-check

Conversation

@gzliudan
Copy link
Copy Markdown
Collaborator

Proposed changes

Refactor the EVM interpreter to clarify and optimize jump table access. This improves code readability and may slightly enhance performance. No logic is changed.

Ref: ethereum#32068

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

…thereum#32068

Refactor the EVM interpreter to clarify and optimize jump table access. This improves code readability and may slightly enhance performance. No logic is changed.
Copilot AI review requested due to automatic review settings April 20, 2026 07:37
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 62ab2b4e-b20a-44d8-8fcd-b0ccc7919c02

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Optimizes the EVM interpreter’s hot loop in core/vm by caching the jump table pointer locally and forcing the jump table nil-check to occur once before entering the opcode dispatch loop, aiming for slightly improved performance and clearer jump table access.

Changes:

  • Cache evm.table into a local jumpTable variable used for opcode dispatch.
  • Hoist the jump table nil-check out of the interpreter loop via a single pre-loop array access.
  • Replace per-iteration evm.table[op] access with jumpTable[op].

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants