Skip to content

fix(eth/downloader): fix flaky test TestFakedSyncProgress64Full #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gzliudan wants to merge 1 commit into
base: dev-upgrade
Choose a base branch
from
+5 −1
Open

fix(eth/downloader): fix flaky test TestFakedSyncProgress64Full #2320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eth/downloader/downloader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,7 +1454,11 @@ func testFakedSyncProgress(t *testing.T, protocol int, mode SyncMode) {
// Create and sync with an attacker that promises a higher chain than available.
brokenChain := chain.shorten(chain.len())
numMissing := 5
for i := brokenChain.len() - 2; i > brokenChain.len()-numMissing; i-- {
// Remove the advertised tail inclusively so the attacker is short by exactly
// numMissing heights. The valid peer below is shortened by the same amount,
// so both the reduced HighestBlock and the final CurrentBlock must converge
// to chain.len()-numMissing-1.
for i := brokenChain.len() - 2; i >= brokenChain.len()-numMissing; i-- {
delete(brokenChain.headerm, brokenChain.chain[i])
}
tester.newPeer("attack", protocol, brokenChain)
Expand Down
Loading