refactor(common/constants): move ignoreSignerCheckBlockArray and denylist to shared global file

[gzliudan]

Proposed changes

• Consolidate ignoreSignerCheckBlockArray and denylist into constants.shared.go for all networks
• Remove per-network duplication and related code
• Update related functions to use shared global variables

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4154ab07-eacd-4ca4-a668-9d53117cc8a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors common network constants by deduplicating the ignoreSignerCheckBlockArray and denylist data across networks and centralizing the related helper functions.

Changes:

• Removed per-network ignoreSignerCheckBlockArray and denylist entries from constants.{mainnet,testnet,devnet,local}.go.
• Introduced common/constants.shared.go with shared global maps and IsIgnoreSignerCheckBlock / IsInDenylist helpers.
• Simplified common/constants.all.go by removing struct fields and CopyConstants map-copy logic tied to those collections.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
common/constants.shared.go	Adds shared global denylist + ignore-signer-check maps and lookup helpers.
common/constants.all.go	Removes per-network fields/copying logic for denylist/ignore-signer-check data.
common/constants.mainnet.go	Removes embedded denylist/ignore-signer-check data from mainnet constants.
common/constants.testnet.go	Removes embedded denylist/ignore-signer-check data from testnet constants.
common/constants.devnet.go	Removes embedded denylist/ignore-signer-check data from devnet constants.
common/constants.local.go	Removes empty local overrides for denylist/ignore-signer-check data.

Comments suppressed due to low confidence (1)

common/constants.all.go:173

• CopyConstants no longer updates the denylist / ignore-signer-check collections when switching networks, so any runtime chainID switch will keep using the shared globals regardless of selected network. If different networks are meant to have different values (notably local previously had empty sets), please reintroduce per-network selection in CopyConstants (either by reassigning the active maps or by storing them on the constant struct again).

// CopyConstants only handles testnet, devnet, local network.
// It skips mainnet since the default value is from mainnet.
func CopyConstants(chainID uint64) {
	log.Info("[CopyConstants]", "chainID", chainID)
	var c *constant
	switch chainID {
	case MainnetConstant.chainID:
		log.Info("[CopyConstants] mainnet chainID matched, no need to copy constants")
		return
	case TestnetConstant.chainID:
		log.Info("[CopyConstants] testnet chainID matched, copying testnet constants")
		c = &TestnetConstant
		IsTestnet = true
	case DevnetConstant.chainID:
		log.Info("[CopyConstants] devnet chainID matched, copying devnet constants")
		c = &DevnetConstant
	default: // local custom chain, it can have any chainID
		log.Info("[CopyConstants] local chainID matched, copying local constants")
		c = &localConstant
	}
	c.print()

	MaxMasternodesV2 = c.maxMasternodesV2
	DenylistHFNumber = c.denylistHFNumber

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.