Group all "bxt_remove_" stuffs into one module, add a bunch of stuffs to it, and add "bxt_clear"#121
Open
khanghugo wants to merge 1 commit into
Open
Group all "bxt_remove_" stuffs into one module, add a bunch of stuffs to it, and add "bxt_clear"#121khanghugo wants to merge 1 commit into
khanghugo wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/modules/remove_stuffs.rs:9
- [nitpick] Consider using a more descriptive name than 'RemoveStuffs' (e.g., 'RemoveVisualElements' or 'DisplayRemoval') to more clearly indicate the module's purpose.
pub struct RemoveStuffs;
src/modules/remove_stuffs.rs:16
- [nitpick] The description 'Removing visible stuffs from the game' could be made more precise—for example, 'Removing visual elements from the game'—to enhance clarity.
fn description(&self) -> &'static str {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #114
This is mainly a port of many cvars from BXT.
I want "bxt_remove_crosshair" to remove any crosshair but it only removes sprite crosshair, which Half-Life and probably every other mods use. But I want to remove CS 1.6 crosshair and it is some OpenGL drawings.
I want "bxt_remove_vgui" to remove spectator GUI in CS 1.6 but it basically disables lots of elements in the game because many elements in the games are drawn coupled with VGUI2, LOL. BXT has similar cvar and it doesn't work really well because it disables VGUI1, not VGUI2. This cvar feels very useless but many other people might find it useful (given that they have a dedicated
bxt_remove_vgui 0because removing VGUI1/2 will disable console command).The only way to remove CS 1.6 crosshair and spectator GUI is to inject into client code.
Anyways, the rest of other cvars are okay when used with
bxt_clear. With that, people don't need to inject BXT to do green screen stuffs.