Add bxt_cap_time_*#68
Draft
khanghugo wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
I am not sure how the |
Contributor
Author
|
This can be made as a different module I think. Or maybe it can stay vaporware. |
YaLTeR
reviewed
Jul 14, 2023
YaLTeR
left a comment
YaLTeR
left a comment
Owner
There was a problem hiding this comment.
Yea idk this does make sense, need to figure out how to best do it.
| } | ||
|
|
||
| capture_video_per_demo::stop(marker); | ||
| TIME.set(marker, 0.); |
Owner
There was a problem hiding this comment.
Needs to be zeroed on cap start, not stop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working with campath and sometimes I just want to capture a segment. Currently there is no way to scrub through demo quickly and this just seems to do the trick. Tested with normal and sampling capture.
The idea is just to have things working around
playdemoand very easy to automate with.