fix: keep hold window open when aircraft overflies hold point - #12
Merged
Conversation
vatSys advances OverflownIndex past the hold point when the aircraft enters the hold, causing the window to close. Now checks if the hold point is the most recently overflown waypoint before treating the hold as cancelled. Fixes #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11.
The hold window was closing when an aircraft entered the hold because vatSys marks the hold point as overflown on entry. The plugin now checks whether the hold point is the most recently overflown waypoint before treating the hold as cancelled.