Add compatibility check mail report for NC apps as a weekly cron

[DeMiro5001]

Problem

• A lot of failed upgrades because "app" is not compatible with the next version of nextcloud

Solution

• Cron weekly to check installed nextcloud's apps for updates and compatibility issues and send email report to root

PR Status

• Code finished and ready to be reviewed/tested
• The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[DeMiro5001]

The mail report will look like this one :

Nextcloud Health Report (Host: domain.tld)
==========================================
Current Version: 31.0.11 (PHP 8.3)
Target Version : 32

 [!] APP UPDATES AVAILABLE
--------------------------
spreed new version available: 21.1.8
forms new version available: 5.2.4
calendar_resource_management new version available: 0.11.0
collectives new version available: 3.5.0
dicomviewer new version available: 2.3.2
event_update_notification new version available: 2.8.0
polls new version available: 8.6.3
whiteboard new version available: 1.5.6
contacts new version available: 7.3.13
calendar new version available: 5.5.14

 [!] INCOMPATIBILITY WARNING (Target: v32)
--------------------------------------------------
Apps installed but NOT marked compatible with v32:

files_mindmap
sharepoint

[DeMiro5001]

I have set it to run weekly. I think it's enough

[DeMiro5001]

!testme

[yunohost-bot]

📖 🪱

[ericgaspar]

I don't know about this feature, it adds maybe complexity where it seems that we already have a function that checks the compatibility of the app with the version of Nextcloud to be installed.

nextcloud_ynh/scripts/upgrade

Line 86 in 4a0b89b

function list_installed_apps_not_compatible_with_future_version()

[DeMiro5001]

That's the point, this checks for incomparable apps before running the upgrade, avoiding failed upgrades reported multiple times in the forum.

[ericgaspar]

That's the point, this checks for incomparable apps before running the upgrade, avoiding failed upgrades reported multiple times in the forum.

This solution does not prevent users from upgrading to the latest version of Nextcloud while having incompatible apps.
If the upgrade script's mechanism for identifying incompatible apps doesn't work properly (i.e. if it fails to highlight the apps preventing the new Nextcloud version from being installed), we should fix it rather than adding more complexity to the script IMO.


[DeMiro5001]

So the upgrade should update all NC apps and disable non compatible apps before proceeding to the actual upgrade. But disabling apps can make people disappointed, they might expect one particular app to be working after upgrade and find themselves unable to use it.
I am using the script on my 3 servers and I have one of them reporting two apps incompatible with the next version of NC. So I'm waiting for these apps to become compatible because there is no workaround (unless I missed something).

[ericgaspar]

Ideally, the update script should:

• check that all apps are up to date.
• update outdated apps.
• Check that the updated apps are compatible with the Nextcloud installation.
• If no compatible apps are found, output a report on the incompatible apps and cancel the installation without breaking Nextcloud.
• If all apps are compatible, proceed with installation.