fix(ethereum): add consensus_rpc fallback cascade; error on missing execution_rpc#709
Open
sashass1315 wants to merge 1 commit intoa16z:masterfrom
Open
fix(ethereum): add consensus_rpc fallback cascade; error on missing execution_rpc#709sashass1315 wants to merge 1 commit intoa16z:masterfrom
sashass1315 wants to merge 1 commit intoa16z:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When only network was provided (no explicit consensus_rpc or full config), the builder ignored base_config.consensus_rpc and panicked via expect, despite networks supplying default consensus endpoints. Additionally, in the non-verifiable API path, the code unwrapped execution_rpc, causing a panic if it was missing, instead of returning a clear configuration error.
Why these changes are needed: The builder should honor network defaults and never panic in library code for expected misconfigurations. Using base_config.consensus_rpc as a fallback aligns with the network presets and documentation, and returning an explicit error for missing execution_rpc (when verifiable_api is not set) provides a clear, recoverable signal to callers.