Remove unused execution_rpc CLI parameter from opstack server#711
Open
sashaodessa wants to merge 1 commit intoa16z:masterfrom
Open
Remove unused execution_rpc CLI parameter from opstack server#711sashaodessa wants to merge 1 commit intoa16z:masterfrom
sashaodessa wants to merge 1 commit intoa16z:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Removes unused
execution_rpcCLI parameter from the opstack server binary that was declared but never used.Problem
The
execution_rpcfield in theClistruct was defined as a required CLI argument but was never referenced in the code. This created a misleading interface where users could pass a flag that would be silently ignored.Solution
execution_rpc: Urlfield from theClistructImpact