fix: check_head_age() to avoid bogus OutOfSync when latest block is missing#736
Open
phrwlk wants to merge 1 commit intoa16z:masterfrom
Open
fix: check_head_age() to avoid bogus OutOfSync when latest block is missing#736phrwlk wants to merge 1 commit intoa16z:masterfrom
phrwlk wants to merge 1 commit intoa16z:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation returned OutOfSync with the current epoch seconds when the Latest block was missing, which misrepresented the delay as an enormous number of seconds behind and produced misleading RPC errors. OutOfSync(u64) is meant to carry the computed delay, not a timestamp. This change treats the absence of the Latest block as BlockNotFound(latest), preserving accurate semantics while leaving the computed-delay path intact for cases where a head timestamp exists. Callers do not rely on the numeric delay value in this branch, so the change is behaviorally correct and improves diagnostics.