Skip to content

Update block_cache.rs #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oooLowNeoNooo wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −8
Open

Update block_cache.rs #748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions core/src/execution/providers/block/block_cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,15 +128,30 @@ impl<N: NetworkSpec> BlockProvider<N> for BlockCache<N> {
if let Some(parent_block) = blocks.get(&(block_number - 1)) {
parent_block.header().hash() == parent_hash
} else {
// No parent block in cache - check if cache is empty except finalized blocks
// No parent block in cache - check if new block continues from finalized or latest block
let finalized = self.finalized.read().await;
if let Some((latest_number, _)) = blocks.last_key_value() {
// All blocks in cache are finalized
*latest_number
<= finalized
.as_ref()
.map(|block| block.header().number())
.unwrap_or_default()
if let Some((latest_number, latest_block)) = blocks.last_key_value() {
// Check if new block continues from finalized block
if let Some(finalized_block) = finalized.as_ref() {
let finalized_number = finalized_block.header().number();
if block_number == finalized_number + 1 {
parent_hash == finalized_block.header().hash()
} else if block_number == *latest_number + 1 {
// Check if new block continues from latest block in cache
latest_block.header().hash() == parent_hash
} else {
// Block doesn't continue from any known block
false
}
} else {
// No finalized block - check if new block continues from latest block
if block_number == *latest_number + 1 {
latest_block.header().hash() == parent_hash
} else {
// Block doesn't continue from any known block
false
}
}
} else {
// Block cache is completely empty
true
Expand Down