Skip to content

fix: remove redundant address list in get_execution_hint#759

Open
prestoalvarez wants to merge 2 commits intoa16z:masterfrom
prestoalvarez:patch-2
Open

fix: remove redundant address list in get_execution_hint#759
prestoalvarez wants to merge 2 commits intoa16z:masterfrom
prestoalvarez:patch-2

Conversation

@prestoalvarez
Copy link
Copy Markdown

The get_execution_hint method created a snapshot list_addresses from the access list before mutating it, then used contains() checks against this stale snapshot. This could allow duplicate addresses to be added when addresses overlap (e.g., from == to, or when from/to are unset and default to the same address).

Removed the intermediate list_addresses vector and replaced contains() checks with direct iter().any() checks against the current list state before each push().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant