fix: remove redundant address list in get_execution_hint#759
Open
prestoalvarez wants to merge 2 commits intoa16z:masterfrom
Open
fix: remove redundant address list in get_execution_hint#759prestoalvarez wants to merge 2 commits intoa16z:masterfrom
prestoalvarez wants to merge 2 commits intoa16z:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_execution_hintmethod created a snapshotlist_addressesfrom the access list before mutating it, then usedcontains()checks against this stale snapshot. This could allow duplicate addresses to be added when addresses overlap (e.g.,from == to, or whenfrom/toare unset and default to the same address).Removed the intermediate
list_addressesvector and replacedcontains()checks with directiter().any()checks against the currentliststate before eachpush().