fix: pin get_code_at to proof block in RpcExecutionProvider#780
Open
Galoretka wants to merge 1 commit intoa16z:masterfrom
Open
fix: pin get_code_at to proof block in RpcExecutionProvider#780Galoretka wants to merge 1 commit intoa16z:masterfrom
get_code_at to proof block in RpcExecutionProvider#780Galoretka wants to merge 1 commit intoa16z:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
get_code_atin [RpcExecutionProvider::get_account]helios/verifiable-api/server/src/service.rs
Lines 58 to 111 in 4a32ac1
.block_id(), defaulting tolatest. Meanwhileget_proofright aboveit was pinned to a specific block hash. If a new block arrived between the two RPC calls, the returned code could belong to a different state than the proof, causing a spurious
CodeHashMismatcherror.What
Added
.block_id(block.header().hash().into())to theget_code_atcall so it queries the same block asget_proof. This matches how every other callsite in the codebase already usesget_code_at.