Draft
Conversation
…I responses This should result in the TF provider being a little more resistant to upstream field changes.
The `status` and `created` fields on ably_api_key are purely computed, server-owned values. They were using DefaultInt64Attribute(0) as a plan modifier, which is meant for Optional+Computed fields where you want a sensible default when the user doesn't provide a value. This worked before 787fffc because the old modifier logic had an early return when PlanValue was unknown, which is exactly what happens for a computed field on create. The reconciliation commit rewrote the modifier to remove that guard, so it now actively sets the plan value to 0. The API then returns the real timestamp, and Terraform sees 0 vs 1776... and throws "Provider produced inconsistent result after apply". Replacing with int64planmodifier.UseStateForUnknown(), which is the correct modifier for computed-only fields. On create it leaves the value as unknown (Terraform accepts any value filling in an unknown), and on update it carries forward the existing state. This is the same pattern already used for the `key` field on the same resource. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opening a draft for tests to run