Skip to content

Nlaw - Update to use Missile Guidance Framework#10034

Merged
PabstMirror merged 286 commits into
masterfrom
missile_nlaw
Aug 23, 2024
Merged

Nlaw - Update to use Missile Guidance Framework#10034
PabstMirror merged 286 commits into
masterfrom
missile_nlaw

Conversation

@TheCandianVendingMachine
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • Update NLAW

Merge Strategy

you know the drill

Follow #10019

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Copy Markdown
Contributor

it's pretty good, but maybe a little sluggish to make turns as expected?
pre

};

private _yawRateDifference = _yawChange - _yawRate;
private _yawChangeDerivative = if (_timestep == 0) then {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var not used

@TheCandianVendingMachine
Copy link
Copy Markdown
Contributor Author

it's pretty good, but maybe a little sluggish to make turns as expected?

So this error has been present ever since the rewrite and I have been trying to determine why since. Right now, my thinking is that there is an accumulated error in the autopilot.

Although, in the limit, the real turn rate will equal the calculated turn rate, because this rate is achieved off-path it will not turn as desired. My current thinking for a solution would be to calculate a new target turn rate each dt so it can follow the predicted path.

Why don't we just set the yaw and pitch rate to be the calculated rate at launch? Good question! This was the idea in the first implementation, but (and forgive me for not remembering specifics) it would not follow the path still. I think what happened was that the missile would fly into the ground eventually due to no altitude holding correction, and this bug was present in the yaw as well in some scenarios.

The bug you showed is the only reason this missile has "known bugs", and I don't know the correct route to solve it; my vector math skills are very slow

@PabstMirror PabstMirror added this to the 3.18.0 milestone Aug 16, 2024
Base automatically changed from missile_guidance_rewrite to master August 23, 2024 14:21
@PabstMirror PabstMirror changed the base branch from master to release August 23, 2024 14:34
@PabstMirror PabstMirror changed the base branch from release to master August 23, 2024 14:35
@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Aug 23, 2024
@PabstMirror PabstMirror merged commit a1cafef into master Aug 23, 2024
@PabstMirror PabstMirror deleted the missile_nlaw branch August 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Release Notes: **CHANGED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.