Skip to content

Arsenal - Add magazine classname searching & improve left hand search#11393

Open
SpicyBagpipes wants to merge 4 commits into
acemod:masterfrom
SpicyBagpipes:patch-9
Open

Arsenal - Add magazine classname searching & improve left hand search#11393
SpicyBagpipes wants to merge 4 commits into
acemod:masterfrom
SpicyBagpipes:patch-9

Conversation

@SpicyBagpipes
Copy link
Copy Markdown
Contributor

@SpicyBagpipes SpicyBagpipes commented May 31, 2026

When merged this pull request will:

  • Allow searching via magazines
    • Only exact matches (given I figure it's getting ctrl+c'd anyway)
    • Will NOT try to look through compatibleMagazines if the search term is not an exact match for a magazine classname.
  • Make <Empty> always show even through searches.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@SpicyBagpipes
Copy link
Copy Markdown
Contributor Author

SpicyBagpipes commented May 31, 2026

idk if <empty> disappearing after the search changes ever bugged anyone else when searching but it really annoyed me so i just did it while in the area

@SpicyBagpipes
Copy link
Copy Markdown
Contributor Author

Todo: not check the search term is a magazine literally every item idk what I was thinking

@SpicyBagpipes
Copy link
Copy Markdown
Contributor Author

goofy ass automatic commit name

did the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant