-
-
Notifications
You must be signed in to change notification settings - Fork 16
Update to schema v31 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frisi
wants to merge
6
commits into
acoustid:main
Choose a base branch
from
molindo:MD-131-schema-update-v31
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c55c139
update to schema v30
084990c
update sql scripts (via `./scripts/update_sql.sh`)
4237f63
update upgrade scripts
4c601fc
mention search_path problem and possible fix
e2c2bde
update to schema v31
f652ea4
fix renamed dbmirror2 script
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # Copyright (C) 2013 Lukas Lalinsky | ||
| # Distributed under the MIT license, see the LICENSE file for details. | ||
|
|
||
| __version__ = "29.1.0" | ||
| __version__ = "31.0.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| -- Helper script to create all dbmirror2 replication triggers. | ||
| \ir CreateReplicationTriggers2.sql | ||
| \ir caa/CreateReplicationTriggers2.sql | ||
| \ir documentation/CreateReplicationTriggers2.sql | ||
| \ir statistics/CreateReplicationTriggers2.sql | ||
| \ir eaa/CreateReplicationTriggers2.sql | ||
| \ir wikidocs/CreateReplicationTriggers2.sql | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| \set ON_ERROR_STOP 1 | ||
|
|
||
| BEGIN; | ||
|
|
||
| CREATE TRIGGER sanitize_dbmirror2_editor_data | ||
| BEFORE INSERT ON dbmirror2.pending_data | ||
| FOR EACH ROW WHEN (NEW.tablename = 'musicbrainz.editor') | ||
| EXECUTE PROCEDURE sanitize_dbmirror2_editor_data(); | ||
|
|
||
| COMMIT; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CreateAllReplicationTriggers2.sqldoesn’t include custom trigger creation.Line 2 starts the “all triggers” include chain, but custom triggers are not included. That can leave dbmirror2 trigger setup incomplete when this helper is used as the entrypoint.
Suggested patch
-- Helper script to create all dbmirror2 replication triggers. \ir CreateReplicationTriggers2.sql +\ir CreateCustomReplicationTriggers2.sql \ir caa/CreateReplicationTriggers2.sql \ir documentation/CreateReplicationTriggers2.sql \ir statistics/CreateReplicationTriggers2.sql \ir eaa/CreateReplicationTriggers2.sql \ir wikidocs/CreateReplicationTriggers2.sql📝 Committable suggestion
🤖 Prompt for AI Agents