PIVOT-13635: Upgrade to Java 25#93
Merged
Merged
Conversation
Closed
tibdex
reviewed
Apr 16, 2026
Member
There was a problem hiding this comment.
Please also change this:
Line 29 in 0577997
Nothing in this repo would benefit from new features of Python 3.11 or 3.12 so let's keep supporting Python >= 3.10.
Can you also check if the content of the LICENSE at the root of the repo is still the right one for Java 25?
Contributor
Author
I downloaded temurin 25.0.2, copy paste the license file and check the diff in git: there is one change, a extra blank line in our license file |
tibdex
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #86.
I was wondering if we should bump also the minimal python version