-
Notifications
You must be signed in to change notification settings - Fork 13
feat(csharp): make the driver AOT/trim-safe under net10.0 #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CurtHagenlocher
wants to merge
5
commits into
adbc-drivers:main
Choose a base branch
from
CurtHagenlocher:PrepareAot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
26c483f
feat(csharp): make the driver AOT/trim-safe under net10.0
CurtHagenlocher 6654fdf
refactor(csharp): streamline complex-type JSON writer and cover the A…
CurtHagenlocher 261b4f7
Update csharp/src/ComplexTypeSerializingStream.cs
CurtHagenlocher f3947e9
Merge branch 'main' into PrepareAot
CurtHagenlocher 9230d5b
test(csharp): add complete test coverage for ComplexTypeSerializingSt…
CurtHagenlocher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Copyright (c) 2026 ADBC Drivers Contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System.Collections.Generic; | ||
| using System.Text.Json; | ||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace AdbcDrivers.Databricks | ||
| { | ||
| /// <summary> | ||
| /// System.Text.Json source-generated metadata for the free-form configuration file, which is | ||
| /// read as a flat <see cref="Dictionary{TKey,TValue}"/> of string-to-string. Using the | ||
| /// generated context keeps the deserialization trim- and NativeAOT-safe. The options mirror | ||
| /// the prior runtime options: case-insensitive property names, comments skipped, and trailing | ||
| /// commas allowed. | ||
| /// </summary> | ||
| [JsonSourceGenerationOptions( | ||
| PropertyNameCaseInsensitive = true, | ||
| ReadCommentHandling = JsonCommentHandling.Skip, | ||
| AllowTrailingCommas = true)] | ||
| [JsonSerializable(typeof(Dictionary<string, string>))] | ||
| internal partial class DatabricksConfigJsonContext : JsonSerializerContext | ||
| { | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| /* | ||
| * Copyright (c) 2026 ADBC Drivers Contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace AdbcDrivers.Databricks | ||
| { | ||
| /// <summary> | ||
| /// System.Text.Json source-generated metadata for <see cref="FeatureFlagsResponse"/> so the | ||
| /// feature-flag response is deserialized without reflection (trim- and NativeAOT-safe). | ||
| /// </summary> | ||
| [JsonSerializable(typeof(FeatureFlagsResponse))] | ||
| internal partial class FeatureFlagsJsonContext : JsonSerializerContext | ||
| { | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Copyright (c) 2026 ADBC Drivers Contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace AdbcDrivers.Databricks.Result | ||
| { | ||
| /// <summary> | ||
| /// System.Text.Json source-generated metadata for <see cref="DescTableExtendedResult"/> | ||
| /// (the <c>DESC EXTENDED … AS JSON</c> response). Used so the deserialization is trim- and | ||
| /// NativeAOT-safe. Default options match the prior parameterless deserialize calls. | ||
| /// </summary> | ||
| [JsonSerializable(typeof(DescTableExtendedResult))] | ||
| internal partial class DescTableJsonContext : JsonSerializerContext | ||
| { | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.