test(csharp): enable client telemetry for all e2e tests#515
Merged
Conversation
Force adbc.databricks.telemetry.enabled=true in
DatabricksTestEnvironment.GetDriverParameters so every e2e connection emits
real telemetry to {host}/telemetry-ext under the current driver version.
Telemetry is off by default (TelemetryConfiguration.Enabled = false), which
is why only stale builds (0.23.0-SNAPSHOT) currently appear in
prod_frontend_log_sql_driver_log and no current-version traffic reaches
lumberjack. Setting the property at the test-env layer gives the e2e suite
real, current-build telemetry coverage.
Co-authored-by: Isaac
msrathore-db
approved these changes
Jun 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Force
adbc.databricks.telemetry.enabled=trueinDatabricksTestEnvironment.GetDriverParameters, so every e2e connection now emits real client telemetry to{host}/telemetry-ext.Why
Telemetry is off by default (
TelemetryConfiguration.Enabled = false). As a result, the only ADBC traffic currently landing inmain.eng_lumberjack.prod_frontend_log_sql_driver_logcomes from a stale build (0.23.0-SNAPSHOT+b716671, commit for #341) — no current-version (1.1.4) telemetry reaches lumberjack at all. Enabling it at the test-env layer gives the e2e suite real, current-build telemetry coverage (session/statement/metadata events, retry/chunk fields, etc.) and a live signal that the export path works end-to-end against the real endpoint.Scope / impact
csharp/test/E2E/DatabricksTestEnvironment.cs); no driver/runtime code changes./telemetry-ext. This is intentional. Sends are non-blocking and guarded by the circuit breaker, so a telemetry failure cannot fail a functional test.telemetryEnabledfield can override it without conflict.Verification
Build could not be run locally due to an unrelated
net10.0submodule/SDK mismatch. To confirm end-to-end: withDATABRICKS_TEST_CONFIG_FILEset (non-SEA, with token), run an e2e test (e.g.CloudFetchE2ETest), wait ~30 min for ingestion, then queryprod_frontend_log_sql_driver_logfor a freshdriver_version LIKE '1.1.4%'row — absent onmain, present with this change.This pull request and its description were written by Isaac.