feat(backup.sh): add separate s3 bucket functionality for kuberesources#88
Draft
eyenx wants to merge 2 commits into
Draft
feat(backup.sh): add separate s3 bucket functionality for kuberesources#88eyenx wants to merge 2 commits into
eyenx wants to merge 2 commits into
Conversation
Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
Member
Author
|
Not sure what the state of this is, therefore putting this on DRAFT |
tongpu
reviewed
Sep 11, 2024
Member
tongpu
left a comment
tongpu
left a comment
There was a problem hiding this comment.
Looks fine at first glance.
Is there a reason you switched to 4 spaces indentation or did you simply change your linter. 😛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #83
Sets new
OCP_BACKUP_KUBERESOURCSES_S3_*variables, to push kuberesources which may contain the encrypted keys for the etcd backup (if encryption is enabled on etcd) to a separate bucket.Only works when using S3, not yet when only using local backup folder.
See https://docs.openshift.com/container-platform/4.12/backup_and_restore/control_plane_backup_and_restore/backing-up-etcd.html