This repository was archived by the owner on May 10, 2021. It is now read-only.
Update setupEnv-android-mac.js#73
Open
Luci2015 wants to merge 7 commits into
Open
Conversation
Luci2015
commented
Dec 17, 2018
Luci2015
commented
Collaborator
- copyright update
- removal of unnecessary functions and imports
- fixing the double PATH env variable creation for /platform-tools and /tools
- roll-back the android_home as per the 'aemm platform install android' default location instead of Android Studio default sdk path
- using quotes for existing PATH values so that errors for existing "space" char inside PATH be averted
- copyright update - removal of unnecessary functions and imports - fixing the double PATH env variable creation for /platform-tools and /tools - roll-back the android_home as per the 'aemm platform install android' default location instead of Android Studio default sdk path - using quotes for existing PATH values so that errors for existing "space" char inside PATH be averted
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 38.25% 38.16% -0.09%
==========================================
Files 25 25
Lines 1286 1289 +3
Branches 167 167
==========================================
Hits 492 492
- Misses 794 797 +3
Continue to review full report at Codecov.
|
Fixing error for AVD creation fail by updating the ./android command to be adapted to the 27.0.1 build and platform. This is just to escape the error, but the emulator will not work anymore since it will require /emulator/emulator from the Android Studio Tools.
android-emulator -> using dedicated emulator; chaning path to emulator install src/platform-android.js: -> changing download source to be the android studio tools instead of a default sdk -> use sdkmanager to download packages instead of deprecated ./android -> use avdmanager to create AVD instead of deprecated ./android -> updated packages to install along with platform android-27 (extras;google;google_play_services required for the gradle fodler that changed location since android-24)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.