Sync with 0de39b0#88
Merged
Merged
Conversation
compute_smooth_direction_field_on_facets: `const auto R01 = ...` deduced an Eigen expression template that referenced the temporaries returned by levi_civita_nrosy() by value, leaving R01 with dangling references after the full-expression. Eager-evaluate into a concrete Matrix<Scalar, 2, 2> to materialize the product before the temporaries are destroyed. Fixes the ASan stack-use-after-scope and the gcc-14 -Werror=maybe-uninitialized false-positive that broke the Python wheel build. unflip_uv_charts: multiple facets sharing a UV vertex caused TSan to flag benign concurrent same-byte writes to uv_vertex_flipped. Switch to std::vector<std::atomic<uint8_t>> with relaxed ordering, matching the existing pattern in remove_occluded_instances.cpp. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
qnzhou
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.