Skip to content

fix: deploy only granted suggestions for summitPlg for ASO UI#2065

Merged
sandsinh merged 8 commits intomainfrom
SITES-41999
Apr 8, 2026
Merged

fix: deploy only granted suggestions for summitPlg for ASO UI#2065
sandsinh merged 8 commits intomainfrom
SITES-41999

Conversation

@sandsinh
Copy link
Copy Markdown
Contributor

@sandsinh sandsinh commented Mar 30, 2026 •
edited
Loading

Summary

  • Block autofix requests for non-granted suggestions when summit-plg is enabled
  • Before processing autofix, checks if any requested suggestion IDs are not granted via SuggestionGrant.splitSuggestionsByGrantStatus()
  • Returns 403 Forbidden with the list of ungranted suggestion IDs if any are found

Test plan

  • Added unit test verifying 403 is returned when ungranted suggestions are included in autofix request
  • Added unit test verifying autofix proceeds when all suggestions are granted (summit-PLG enabled)
  • Added unit test verifying grant status is not checked when summit-PLG is disabled
  • Verified existing autofix tests still pass (granted suggestions proceed normally)

Related Issues

Resolves SITES-41999

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

This PR will trigger a patch release when merged.

@sandsinh @claude
test: add autofix suggestions tests for summit-plg grant status
e692f3d 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tarunsinghdev
tarunsinghdev approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tarunsinghdev tarunsinghdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sandsinh sandsinh merged commit f9a70d8 into main Apr 8, 2026
20 checks passed
@sandsinh sandsinh deleted the SITES-41999 branch April 8, 2026 10:59
solaris007 pushed a commit that referenced this pull request Apr 8, 2026
@semantic-release-bot
chore(release): 1.421.1 [skip ci]
b9f8d5d 
## [1.421.1](v1.421.0...v1.421.1) (2026-04-08)

### Bug Fixes

* deploy only granted suggestions for summitPlg for ASO UI ([#2065](#2065)) ([f9a70d8](f9a70d8))
@solaris007
Copy link
Copy Markdown
Member

solaris007 commented Apr 8, 2026

🎉 This PR is included in version 1.421.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarunsinghdev tarunsinghdev tarunsinghdev approved these changes

@Kanishkavijay39 Kanishkavijay39 Awaiting requested review from Kanishkavijay39

@absarasw absarasw Awaiting requested review from absarasw

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sandsinh @solaris007 @tarunsinghdev