feat: We only need to analyze top 3 pages for PLG customers#2120
feat: We only need to analyze top 3 pages for PLG customers#2120tkotthakota-adobe merged 7 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR will trigger no release when merged. |
There was a problem hiding this comment.
@tkotthakota-adobe This is not in alignment with the token architecture that we implemented. The limits are already getting applied for summit-plg customers and grantedEntities are getting filtered. Please add the pageview sort function here - https://github.com/adobe/spacecat-api-service/blob/main/src/support/grant-suggestions-handler.js#L100 and all limits should automatically apply to cwv.
@sandsinh Can you point me to the PR? Note that these limits only applied to ASO UI display. Ticket: https://jira.corp.adobe.com/browse/SITES-42676 |
|
@sandsinh I see more than top 3 pages listed under CWV for few sites on prod and dev. Can you fix this as I understand it was implemented part of token architecture feature to show only top 3 pages? Note that we need to have top 3 pages (not just any 3 pages) for cwv summit-plg customers (probably it applies to other opportunities as well). If this requires more work, unblock us by approving this PR: #2120 This is needed for summit (code freeze is this weekend). Some of the summit-plg sites I checked here: prod: Dev: |
|
🎉 This PR is included in version 1.425.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
https://jira.corp.adobe.com/browse/SITES-42676
https://jira.corp.adobe.com/browse/SITES-42074
Summary:
When a request comes from the Sites Optimizer UI (x-client-type: sites-optimizer-ui header) and the site has the summit-plg handler enabled, CWV opportunity suggestions are limited to the top 3 entries. Since the audit-worker stores suggestions sorted by page views descending, this returns the 3 highest-traffic pages with failing metrics.
We also need to consider confidence score to when sorting top 3 (SITES-42074)
All other clients (reporting, API consumers without the header) receive the full suggestion list unchanged.
Tests: