Skip to content

fix: updated experimentation engine flow#2135

Merged
dipratap merged 19 commits intomainfrom
expe-2
Apr 8, 2026
Merged

fix: updated experimentation engine flow#2135
dipratap merged 19 commits intomainfrom
expe-2

Conversation

@dipratap
Copy link
Copy Markdown
Contributor

@dipratap dipratap commented Apr 6, 2026

Summary

Refactors geo-experiment bootstrapping in the suggestions controller for better configurability and separation of concerns.

  • New geo-experiment-helper.js — extracts getScheduleParams and buildExperimentMetadata helpers. Schedule parameters (cron, expiry, platforms, provider IDs) are driven by an EXPERIMENT_SCHEDULE_CONFIG env var with per-strategy defaults as fallback, making them overridable per environment without code changes.
  • Schedule config embedded in GeoExperiment metadata — resolved pre/post schedule params are stored in geo-experiment at creation time so the experimentation engine can read them directly.
  • Removed AsyncJob creation from the suggestions controller — job lifecycle is now owned entirely by the experimentation engine.
  • Fixed suggestion unblocking in error pathedgeOptimizeStatus is now properly cleared on failure so suggestions don't remain permanently locked.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

This PR will trigger a patch release when merged.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dipratap dipratap marked this pull request as ready for review April 7, 2026 06:24
@dipratap dipratap merged commit f37c9c9 into main Apr 8, 2026
20 checks passed
@dipratap dipratap deleted the expe-2 branch April 8, 2026 11:24
solaris007 pushed a commit that referenced this pull request Apr 8, 2026
## [1.421.2](v1.421.1...v1.421.2) (2026-04-08)

### Bug Fixes

* updated experimentation engine flow ([#2135](#2135)) ([f37c9c9](f37c9c9))
@solaris007
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.421.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants