feat(brands): persist and return URL type field in brand_sites (LLMO-4058)#2149
Open
feat(brands): persist and return URL type field in brand_sites (LLMO-4058)#2149
Conversation
…4058) Update brands-storage to persist the type field (e.g. \"base\") through syncBrandSites and return it on base-URL entries in mapDbBrandToV2. Companion to DRS change that injects baseUrl with type: \"base\". Requires DB migration: ALTER TABLE brand_sites ADD COLUMN type TEXT DEFAULT NULL;
|
This PR will trigger a minor release when merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syncBrandSites()to track and persist thetypefield (e.g."base") from URL entries to thebrand_sitestablemapDbBrandToV2()andBRAND_SELECTto returntypeon base-URL entriesPrerequisite: DB migration required before deploy:
Companion PR: adobe-rnd/llmo-data-retrieval-service#1222 (DRS injects
baseUrlwithtype: "base")Jira: LLMO-4058
Test plan
type: "base", verify GET returns it🤖 Generated with Claude Code