fix: store suggestion ID in data for correct syncSuggestions deduplication#2184
Open
AndreiAlexandruParaschiv wants to merge 1 commit intomainfrom
Open
fix: store suggestion ID in data for correct syncSuggestions deduplication#2184AndreiAlexandruParaschiv wants to merge 1 commit intomainfrom
AndreiAlexandruParaschiv wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datapayload (redditSuggestionId/youtubeSuggestionId)buildKeyto prefer the stored ID over the top-levelidRoot cause:
syncSuggestionscallsbuildKey(s.getData())for existing records, butgetData()returns only thedatasub-object which lacks the suggestionidfield. This caused all existing keys to resolve toreddit::undefined(oryoutube::undefined), marking every suggestion as OUTDATED on every re-run and creating duplicates.