Accessibility fix entity migration#2269
Open
rmanolescu-adobe wants to merge 3 commits intoadobe:mainfrom
Open
Conversation
…tion data Replace direct suggestion.data.patchContent writes with FixEntity creation in processCodeFixUpdates. Each code fix now creates a FixEntity with the patch in changeDetails and links matched suggestions via the junction table. This eliminates duplicate patch content across suggestions sharing an aggregationKey, resolving 413 errors from payload bloat. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update all assertions from suggestion.setData/Suggestion.saveMany to opportunity.addFixEntities with correct FixEntity payload verification. Tests verify: FixEntity creation with changeDetails, suggestion linking, old format support, error handling, and edge cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add per-suggestion try/catch in findMatchingSuggestions so one bad suggestion does not abort all matching - Use Promise.allSettled for update processing so partial results are preserved when individual updates fail - Early-exit bucket validation before the loop so CodeFixConfigurationError still surfaces as a fatal error Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Retry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suggestion.data.patchContentwrites with FixEntity creation inprocessCodeFixUpdateschangeDetailsand links matched suggestions via the junction tableaggregationKey, resolving 413 errors from payload bloatChanges
src/common/codefix-handler.js: RenamedupdateSuggestionsWithCodeChange→findMatchingSuggestions(pure matching, no side effects).processCodeFixUpdatesnow callsopportunity.addFixEntities()instead of writing to suggestion data. Removed unusedSuggestionimport.docs/specs/accessibility-fix-entity-migration/spec.md: Repo-specific implementation specTest plan
npm test)changeDetails.patchContentpatchContentin their data for new fixesGET /fixes/:fixId/suggestionsreturns linked suggestions