Skip to content

fix: llm-error-pages enabled only when cdn-config present #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ymadobe wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Open

fix: llm-error-pages enabled only when cdn-config present #2288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b656d6
fix: llm-error-pages enabled only when cdn-config present
ymadobe Apr 2, 2026
e0c88be
Merge branch 'main' into llm-error-pages-remove-autoenable
ymadobe Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/llmo-customer-analysis/cdn-config-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ export async function handleCdnBucketConfigChanges(context, data) {
const configuration = await Configuration.findLatest();
configuration.disableHandlerForSite('cdn-logs-analysis', site);
configuration.disableHandlerForSite('cdn-logs-report', site);
configuration.disableHandlerForSite('llm-error-pages', site);
configuration.disableHandlerForSite('page-citability', site);
await configuration.save();
throw new Error('CDN provider is required for CDN configuration');
Expand Down Expand Up @@ -218,6 +219,7 @@ export async function handleCdnBucketConfigChanges(context, data) {
const configuration = await Configuration.findLatest();
configuration.enableHandlerForSite('cdn-logs-analysis', site);
configuration.enableHandlerForSite('cdn-logs-report', site);
configuration.enableHandlerForSite('llm-error-pages', site);
configuration.enableHandlerForSite('page-citability', site);
await configuration.save();

Expand Down
1 change: 0 additions & 1 deletion src/llmo-customer-analysis/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,6 @@ export async function runLlmoCustomerAnalysis(finalUrl, context, site, auditCont
'scrape-top-pages',
'headings',
'llm-blocked',
'llm-error-pages',
'summarization',
REFERRAL_TRAFFIC_AUDIT,
'readability',
Expand Down
2 changes: 2 additions & 0 deletions test/audits/llmo-customer-analysis-cdn-config.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ describe('CDN Config Handler', () => {
expect(mockSite.save).to.have.been.called;
expect(mockConfiguration.disableHandlerForSite).to.have.been.calledWith('cdn-logs-analysis', mockSite);
expect(mockConfiguration.disableHandlerForSite).to.have.been.calledWith('cdn-logs-report', mockSite);
expect(mockConfiguration.disableHandlerForSite).to.have.been.calledWith('llm-error-pages', mockSite);
expect(mockConfiguration.disableHandlerForSite).to.have.been.calledWith('page-citability', mockSite);
expect(mockConfiguration.save).to.have.been.called;
expect(context.log.warn).to.have.been.calledWith(
Expand Down Expand Up @@ -413,6 +414,7 @@ describe('CDN Config Handler', () => {
expect(mockSite.save).to.have.been.called;
expect(mockConfiguration.enableHandlerForSite).to.have.been.calledWith('cdn-logs-analysis', mockSite);
expect(mockConfiguration.enableHandlerForSite).to.have.been.calledWith('cdn-logs-report', mockSite);
expect(mockConfiguration.enableHandlerForSite).to.have.been.calledWith('llm-error-pages', mockSite);
expect(mockConfiguration.enableHandlerForSite).to.have.been.calledWith('page-citability', mockSite);
expect(context.log.info).to.have.been.calledWith(
'CDN_CONFIG_CHANGED: CDN bucket configuration updated',
Expand Down
1 change: 0 additions & 1 deletion test/audits/llmo-customer-analysis.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,7 +1241,6 @@ describe('LLMO Customer Analysis Handler', () => {
'scrape-top-pages',
'headings',
'llm-blocked',
'llm-error-pages',
'summarization',
'llmo-referral-traffic',
'readability',
Expand Down
Loading