fix(prerender): skip creating suggestions for deployed-at-edge URLs when domain is fully deployed#2310
Draft
anuj-adobe wants to merge 1 commit intomainfrom
Draft
fix(prerender): skip creating suggestions for deployed-at-edge URLs when domain is fully deployed#2310anuj-adobe wants to merge 1 commit intomainfrom
anuj-adobe wants to merge 1 commit intomainfrom
Conversation
…hen domain is fully deployed When the domain-wide suggestion has edgeDeployed set (isAllDomainDeployedAtEdge=true), individual suggestions for URLs already deployed at edge are excluded from syncSuggestions newData instead of being created as NEW and immediately moved to SKIPPED. Existing SKIPPED suggestions for deployed URLs are safe from OUTDATED because scrapedUrlsSet already excludes isDeployedAtEdge=true URLs from OUTDATED detection. Non-deployed URLs and the domain-wide aggregate suggestion are unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the domain-wide suggestion has
edgeDeployedset (isAllDomainDeployedAtEdge=true), individual suggestions for URLs already deployed at edge were being created asNEWand immediately moved toSKIPPED— a wasteful two-step cycle.convertToOpportunity, checkisAllDomainDeployedAtEdgeand excludeisDeployedAtEdge=trueURLs fromsyncSuggestionsnewData— they are never created in the first placeSKIPPEDsuggestions for deployed URLs are safe fromOUTDATEDbecausescrapedUrlsSetalready excludesisDeployedAtEdge=trueURLs from OUTDATED detectionCases verified
edgeDeployedon domain-wide suggestion)isDeployedAtEdge=trueURLs filtered fromnewData— no NEW suggestion created; existing SKIPPED stays SKIPPED ✓edgeDeployed)isAllDomainDeployedAtEdge=false— filter not applied, NEW suggestion created as before ✓edgeDeployedon URL suggestion)scrapedUrlsSet, not innewData— preserved untouched ✓Test plan
NEWsuggestions are created for deployed-at-edge URLs when domain is fully deployedSKIPPEDsuggestions remainSKIPPEDacross audit runs🤖 Generated with Claude Code